Add JS DOM utils to Scaladoc-js #14595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
force-pushed
the
scaladoc/js-html-utils
branch
from
1faf597 to
39e3fcf
Compare
MarcinAman
reviewed
Mar 2, 2022
| val testId = Attr("data-test-id") | ||
| val alt = Attr("alt") | ||
| val value = Attr("value") | ||
| val onclick=Attr("onclick") |
| val b = Tag[domhtml.Element]("b") | ||
| val i = Tag[domhtml.Element]("i") | ||
|
|
||
| val cls = Attr("class") |
There was a problem hiding this comment.
class, we do not code in C++ to count every character we type
There was a problem hiding this comment.
class is a keyword and I didn't want to type:
`class`
in every tag
BarkingBad
approved these changes
Mar 2, 2022
| @@ -178,22 +155,16 @@ class CodeSnippets: | |||
| case btn: html.Element => btn.parentElement.style = "display:none;" | |||
| case _ => | |||
| } | |||
| div.style = "display:none;" | |||
| bdiv.style = "display:none;" | |||
There was a problem hiding this comment.
Couldnt be this event listerner block inlined in exitButton using tap?
| import org.scalajs.dom._ | ||
| import org.scalajs.dom.ext._ | ||
| import org.scalajs.dom.html.Input | ||
| import scala.scalajs.js.timers._ | ||
| import scala.concurrent.duration._ | ||
| import scala.concurrent.duration.{span => dspan, _} |
There was a problem hiding this comment.
dspan seems unused. Can we just import things we need or import span => _?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.